Skip to content

Qualcomm AI Engine Direct - Fix static cache#16423

Merged
cccclai merged 5 commits intopytorch:mainfrom
CodeLinaro:fix_static_cache
Jan 5, 2026
Merged

Qualcomm AI Engine Direct - Fix static cache#16423
cccclai merged 5 commits intopytorch:mainfrom
CodeLinaro:fix_static_cache

Conversation

@chenweng-quic
Copy link
Collaborator

@chenweng-quic chenweng-quic commented Jan 2, 2026 •
edited by pytorch-bot bot
Loading

Summary

  • Fix static cache used by t5 and whisper
  • Fix online prepare on Mutable buffer
  • Fix minor issues

Test plan

python ${EXECUTORCH_ROOT}/backends/qualcomm/tests/test_qnn_delegate.py -k test_t5 --model SM8650 --build_folder build-android --host <host> --device <device_id>--executorch_root ${EXECUTORCH_ROOT} --artifact_dir ./t5_artifact --qa_dataset SQuAD-v1.1.csv
python ${EXECUTORCH_ROOT}/backends/qualcomm/tests/test_qnn_delegate.py -k test_whisper --model SM8650 --build_folder build-android --host <host> --device <device_id>--executorch_root ${EXECUTORCH_ROOT} --artifact_dir ./whisper_artifact_dir

cc @cccclai @cbilgin

@chenweng-quic
Qualcomm AI Engine Direct - Fix t5 and whisper
2e817da 
- Fix t5 and whisper
- Fix online prepare for mutable buffer
- Fix minor issues
@chenweng-quic chenweng-quic requested a review from cccclai as a code owner January 2, 2026 03:59
@pytorch-bot
Copy link

pytorch-bot bot commented Jan 2, 2026 •
edited
Loading

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/16423

Note: Links to docs will display an error until the docs builds have been completed.

❗ 1 Active SEVs

There are 1 currently active SEVs. If your PR is affected, please view them below:

❌ 2 New Failures, 1 Unrelated Failure

As of commit 9f33327 with merge base c730feb (image):

NEW FAILURES - The following jobs have failed:

UNSTABLE - The following job is marked as unstable, possibly due to flakiness on trunk:

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@meta-cla meta-cla bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Jan 2, 2026
@github-actions
Copy link

github-actions bot commented Jan 2, 2026

This PR needs a release notes: label

If your change should be included in the release notes (i.e. would users of this library care about this change?), please use a label starting with release notes:. This helps us keep track and include your important work in the next release notes.

To add a label, you can comment to pytorchbot, for example
@pytorchbot label "release notes: none"

For more information, see
https://github.com/pytorch/pytorch/wiki/PyTorch-AutoLabel-Bot#why-categorize-for-release-notes-and-how-does-it-work.

@chenweng-quic chenweng-quic added the module: qnn Issues related to Qualcomm's QNN delegate and code under backends/qualcomm/ label Jan 2, 2026
mergennachin
mergennachin approved these changes Jan 2, 2026
View reviewed changes
Copy link
Contributor

@mergennachin mergennachin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

See inline comments

@cccclai cccclai mentioned this pull request Jan 4, 2026
Merged
@cccclai
Copy link
Contributor

cccclai commented Jan 4, 2026

There is lint error, can you fix it?

@cccclai cccclai merged commit 47dc1de into pytorch:main Jan 5, 2026
137 of 140 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@mergennachin mergennachin mergennachin approved these changes

@cccclai cccclai Awaiting requested review from cccclai cccclai is a code owner

Assignees

No one assigned

Labels

CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. module: qnn Issues related to Qualcomm's QNN delegate and code under backends/qualcomm/

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@chenweng-quic @cccclai @mergennachin